Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #1634 (drop finishing spaces and EOL) #1638

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix bug #1634 (drop finishing spaces and EOL) #1638

merged 4 commits into from
Sep 5, 2023

Conversation

GBR-613
Copy link
Contributor

@GBR-613 GBR-613 commented Sep 5, 2023

No description provided.

@GBR-613 GBR-613 mentioned this pull request Sep 5, 2023
Closed
Wauplin
Wauplin approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR for this @GBR-613! If it can avoid problems to users, that's for the best :)

tests/test_utils_hf_folder.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 5, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.35% ⚠️

Comparison is base (94c427a) 82.13% compared to head (b8c49ab) 81.78%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   82.13%   81.78%   -0.35%     
==========================================
  Files          60       60              
  Lines        6746     6749       +3     
==========================================
- Hits         5541     5520      -21     
- Misses       1205     1229      +24
Files Changed Coverage Δ
src/huggingface_hub/utils/_hf_folder.py 95.45% <100.00%> (+0.33%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wauplin Wauplin merged commit 282bda7 into huggingface:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GBR-613 @HuggingFaceDocBuilderDev @Wauplin